the error in clirr would need to be fixed too. I'll try to find some time during the weekend to rollback and post a new release
On Wed, Jul 16, 2008 at 1:27 PM, Vincent Siveton <[EMAIL PROTECTED]> wrote: > Thanks Dennis to fix them. > > BTW Carlos, could you also include a release notes link on the jira > report? We discussed about it recently. > > Cheers, > > Vincent > > 2008/7/16, Dennis Lundberg <[EMAIL PROTECTED]>: >> Thanks for pushing for this release Carlos! >> >> Unfortunately there are a couple of things that needs to be fixed before we >> can release 1.2, for which I have to vote -1 to the current release >> candidate. >> >> - The POM is missing the license header (I fixed this in svn) >> - The Source files have the old license headers (I fixed this in svn) >> - The documentation fix for MANTRUN-75 is not included in the 1.2 tag >> >> Here are some minor things that are nice to fix prior to the release, all >> of which I have fixed in svn trunk. >> >> - Use latest version of maven-plugin-plugin and maven-site-plugin >> - Fix errors reported by Checkstyle >> - Add missing scm info in the POM >> >> The Clirr report [1] shows one error, one of the constructors for >> AntPropertyHelper has changed the number of parameters. This was done in >> r374150 as part of the fix for MANTRUN-41. I guess that we can live with >> that change. Do we need to document it? >> >> >> [1] >> http://maven.apache.org/plugins/maven-antrun-plugin-1.2/clirr-report.html >> >> >> Carlos Sanchez wrote: >> >> > Hi, >> > >> > 9 issues fixed. Last release was 2.5 years ago >> > >> > >> http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11125&styleName=Html&version=12210 >> > >> > Staging repo: >> > http://people.apache.org/~carlos/staging-repo >> > >> > Staging site: >> > >> http://maven.apache.org/plugins/maven-antrun-plugin-1.2/ >> > >> > Guide to testing staged releases: >> > >> http://maven.apache.org/guides/development/guide-testing-releases.html >> > >> > Vote open for 72 hours. >> > >> > [ ] +1 >> > [ ] +0 >> > [ ] -1 >> > >> > >> --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [EMAIL PROTECTED] >> > For additional commands, e-mail: [EMAIL PROTECTED] >> > >> > >> > >> >> >> -- >> Dennis Lundberg >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
