On 23/09/2008, at 11:57 PM, Igor Fedorenko wrote:

Would not it be better to move wagons and anything else not intended to be visible by plugins into a separate classloader?

I believe that is essentially what the container changes on trunk did. Whether it's something along those lines or a simpler alternative that keeps the current extension semantics, this would certainly be better, but shading them might be simpler and more consistent with current behaviour in the short term.

Cheers,
Brett



Brett Porter wrote:
/me cheers
Yep, go for it.
This will also mean producing shaded versions of the wagons though I think, or creating a shaded "built-in wagons" JAR, to prevent some of their dependencies being forced on plugins. The ITs for MNG-3581/3599 might pick this up, but it would be worth an extra IT to verify.
Cheers,
Brett
On 23/09/2008, at 3:00 AM, Jason van Zyl wrote:
I made the uber jar and I think it was a mistake. It's a complete PITA to swap in new jars and test and the shading can work on the JARs necessary.

I would like to remove the uber jar in 2.1 and do it on the 2.2 branch as well.

Any objections?

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
jason at sonatype dot com
----------------------------------------------------------

A party which is not afraid of letting culture,
business, and welfare go to ruin completely can
be omnipotent for a while.

-- Jakob Burckhardt


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

--
Brett Porter
[EMAIL PROTECTED]
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


--
Brett Porter
[EMAIL PROTECTED]
http://blogs.exist.com/bporter/


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to