On 13-Jun-09, at 7:21 AM, Olivier Lamy wrote:
Hi,
It sounds good to remove link between core and doxia..
What is your idea ?
Creating a new plugin ? Moving logic to the site plugin ? Move logic
to maven-reporting-impl or something new ?
I would just encapsulate it all in the maven-site-plugin. I would
honestly just put everything there including all your existing
implementations and even Doxia. The stuff is not used anywhere else
outside the context of the maven-site-plugin. By this I specifically
mean just make a multi-module build of the maven-site-plugin and just
include everything that's used there: doxia, site-tools, and whatever
else. Have it all be decoupled from the core, focus on getting it all
working together, think about modularization again in the future.
Doxia just really has never taken off as a separate project: it's just
not used outside of the site plugin and at this point I think it's
highly unlikely it will. Just get it all working together in a new
encapsulated system would be my suggestion.
If I can help, let me know (I'd like to participate on current trunk
but as a newbie here I don't wan't to break everything :-) ).
You can't break anything on trunk insofar as the maven-site-plugin
because there just isn't any reporting functionality left in there
anymore. You should be able to restore complete functionality to the
maven-site-plugin and when we find things that are missing that you
need it can be added. You need to access the plugin manager to
configure and run the reports, and you'll probably need to perform
some operations at the beginning of the lifecycle and you'll want to
do some aggregation at the end of the lifecycle.
I'm happy to help with any internal changes that might need to be
made. But I would:
- branch the site plugin
- incorporate the configuration that is currently required in the POM
for reporting and include that in the site plugin
- leverage the core to configure and execute the reports
What we can do internally for people who want to use their POMs "as-
is" with 3.x is to provide some internal mapping from the POM to the
configuration element of the new site-plugin. When 3.0 is release no
one should have to change their POMs i.e flip all the configuration
into the maven-site-plugin configuration but they will have to use the
new version of the site-plugin.
If you want to help with this that would be very helpful.
Thanks,
--
Olivier
2009/6/11 Jason van Zyl <[email protected]>:
There's nothing Doxia specific in the core, that was just a lingering
element in the POM.
Plan in a nutshell is that the entire existing reporting mechanism
will be
encapsulated in the site plugin and I will provide any hooks in the
lifecycle to make it work.
The mixture of reports and plugins caused such a massive amount of
pollution
it made it impossible to generalize the plugin manager. It was just
a huge
mess.
Everything has to be extensible including reporting and it can all be
bundled up in a plugin. One of the requirements for the release of
3.0 is to
have the infrastructure to support the current reporting system as
a plugin.
I can make a first pass at the plugin and then you guys can pick it
up.
On 11-Jun-09, at 8:53 AM, Lukas Theussl wrote:
Hi Olivier,
How does this relate to MNG-3402?
Just wondering because we had a lot of discussions about this
issue in the
past wrt Doxia release plan [1], and from other peoples' comments
I always
got the impression that it will lead to trouble... even though I
never
noticed anything myself.
-Lukas
[1] http://www.nabble.com/MNG-3402-tt17207692.html
[email protected] wrote:
Author: olamy
Date: Wed Jun 10 21:30:40 2009
New Revision: 783525
URL: http://svn.apache.org/viewvc?rev=783525&view=rev
Log:
don't filter doxia-sink-api. users will be still able to run : mvn
site:site
Modified:
maven/components/trunk/maven-core/src/main/java/org/apache/maven/
DefaultArtifactFilterManager.java
Modified:
maven/components/trunk/maven-core/src/main/java/org/apache/maven/
DefaultArtifactFilterManager.java
URL:
http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultArtifactFilterManager.java?rev=783525&r1=783524&r2=783525&view=diff
=
=
=
=
=
=
=
=
=
=
=
===================================================================
---
maven/components/trunk/maven-core/src/main/java/org/apache/maven/
DefaultArtifactFilterManager.java
(original)
+++
maven/components/trunk/maven-core/src/main/java/org/apache/maven/
DefaultArtifactFilterManager.java
Wed Jun 10 21:30:40 2009
@@ -54,7 +54,7 @@
artifacts.add( "classworlds" );
artifacts.add( "plexus-classworlds" );
artifacts.add( "commons-cli" );
- artifacts.add( "doxia-sink-api" );
+ //artifacts.add( "doxia-sink-api" );
artifacts.add( "jsch" );
artifacts.add( "maven-artifact" );
artifacts.add( "maven-artifact-manager" );
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------
In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.
-- Jacques Ellul, The Technological Society
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------
Our achievements speak for themselves. What we have to keep track
of are our failures, discouragements and doubts. We tend to forget
the past difficulties, the many false starts, and the painful
groping. We see our past achievements as the end result of a
clean forward thrust, and our present difficulties as
signs of decline and decay.
-- Eric Hoffer, Reflections on the Human Condition
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
