Or should I just create a new component for to hold toolchains and their factories... that way if multiple plugins need the same non-core toolchains, at least there is only one dependency that is needed.
I'm looking at MINVOKER-100 and the supplied patch does not smell good to me, so I'm thinking I need to create maven-toolchain-maven as a project and have the DefaultMavenToolchainFactory and DefaultMavenToolchain in that project rather than end up with 5 or 6 different plugins all having the same/similar duplicate code. Also in that view the DefaultJavaToolchain should probably have been/be removed from core (in an ideal world) to make it more easily extended -Stephen On 5 August 2010 15:27, Stephen Connolly <[email protected]>wrote: > Hmmmm > > So if I want to add more core toolchains I now have to push the changes to > core, or will the classloader always take from core and not from a newer > maven-toolchains dep of a plugin? > > -Stephen > > > On 5 August 2010 15:25, Jason van Zyl <[email protected]> wrote: > >> >> https://svn.apache.org/repos/asf/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/toolchain/ >> >> On Aug 5, 2010, at 10:21 AM, Stephen Connolly wrote: >> >> > Where is maven-toolchain... the last one I can find in SVN: >> > >> https://svn.apache.org/repos/asf/maven/maven-2/branches/maven-2.2.x/maven-toolchain >> > >> > repo1, shows that there was a 3.0-alpha-1 and 3.0-alpha-2 release but no >> > 3.0-beta-1 release... >> > http://repo1.maven.org/maven2/org/apache/maven/maven-toolchain/ >> > >> > So where is it gone to? >> > >> > -Stephen >> >> Thanks, >> >> Jason >> >> ---------------------------------------------------------- >> Jason van Zyl >> Founder, Apache Maven >> http://twitter.com/jvanzyl >> --------------------------------------------------------- >> >> We know what we are, but know not what we may be. >> >> -- Shakespeare >> >> >> >> >
