I'll think about that overnight... and perhaps discuss with Benjamin the implications on IRC tomorrow. If I feel it's better out I'll call a vote first.
If we are taking it out I'd rather see it removed before 3.0-beta-2. My thinking is that we remove the org.apache.maven.toolchain.java package from core and leave the rest where it is. My worries are the implications for plugins running against [2.0.9,3.0.0) * If the plugin depends on the newer maven-toolchain-java artifact... will life be ok -Stephen On 5 August 2010 15:33, Jason van Zyl <[email protected]> wrote: > Maybe just decouple it completely from the core if you think it's going to > vary that much. > > I would be for completely extracting it. > > On Aug 5, 2010, at 10:27 AM, Stephen Connolly wrote: > > > Hmmmm > > > > So if I want to add more core toolchains I now have to push the changes > to > > core, or will the classloader always take from core and not from a newer > > maven-toolchains dep of a plugin? > > > > -Stephen > > > > On 5 August 2010 15:25, Jason van Zyl <[email protected]> wrote: > > > >> > >> > https://svn.apache.org/repos/asf/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/toolchain/ > >> > >> On Aug 5, 2010, at 10:21 AM, Stephen Connolly wrote: > >> > >>> Where is maven-toolchain... the last one I can find in SVN: > >>> > >> > https://svn.apache.org/repos/asf/maven/maven-2/branches/maven-2.2.x/maven-toolchain > >>> > >>> repo1, shows that there was a 3.0-alpha-1 and 3.0-alpha-2 release but > no > >>> 3.0-beta-1 release... > >>> http://repo1.maven.org/maven2/org/apache/maven/maven-toolchain/ > >>> > >>> So where is it gone to? > >>> > >>> -Stephen > >> > >> Thanks, > >> > >> Jason > >> > >> ---------------------------------------------------------- > >> Jason van Zyl > >> Founder, Apache Maven > >> http://twitter.com/jvanzyl > >> --------------------------------------------------------- > >> > >> We know what we are, but know not what we may be. > >> > >> -- Shakespeare > >> > >> > >> > >> > > Thanks, > > Jason > > ---------------------------------------------------------- > Jason van Zyl > Founder, Apache Maven > http://twitter.com/jvanzyl > --------------------------------------------------------- > > To do two things at once is to do neither. > > -—Publilius Syrus, Roman slave, first century B.C. > > > >
