Why does WagonHelper.getWagonResourceFetcher work with only http? Seems rather arbitrary, especially as there seems to be a separate role hint for https, which is by no means an exotic corner case. Would seem better to restore the older and more generic code that used WagonManager.getWagon.

Or is the point just to avoid the (undocumented) deprecation of 
WagonManager.getWagon? So just copy the trivial impl in DefaultWagonManager.

Not exactly a blocking issue for 3.1.0, since as a workaround I can always avoid getWagonResourceFetcher and find the right Wagon myself, but would seem preferable to not introduce a factory method which is broken by design.

(BTW "extends AbstractResourceFetcher implements ResourceFetcher" is redundant.)


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to