Agree it's hard to inject that. So that reduce possible backward comp issues.
BTW what about using this bean/data structure rather than adding new parameters ? 2012/6/29 Milos Kleint <mkle...@gmail.com>: > Is ModelProblemCollector intended for use outside of maven codebase? > MavenModelBuilder is hardcoding reference on DefaultMPC and there's a > few other implementations in tests or compat module only.. > > Milos > > On Fri, Jun 29, 2012 at 11:49 AM, Olivier Lamy <ol...@apache.org> wrote: >> Hi, >> The main issue I see is non backward comp for tools implementing their >> own ModelProblemCollector. >> I don't have issue to change signature but for future enhancement if >> needed here, I would prefer to see something more easy to change and >> don't break again backward comp in the future. >> So instead more parameters >> >> - void add( ModelProblem.Severity severity, String message, >> InputLocation location, Exception cause ); >> >> + void add( ModelProblem.Severity severity, ModelProblem.Version >> version, String message, InputLocation location, Exception cause ); >> >> I would prefer we use a bean which contains the needed informations. >> something like: void add( ModelProblemCollector >> modelProblemCollectorRequest ); (or an other name :-) ). >> >> Makes sense ? >> >> 2012/6/29 Milos Kleint <mkle...@gmail.com>: >>> hello, >>> >>> I've prepared a patch for MavenModelBuilder and related code that >>> hopefully will improve the performance of NetBeans >>> integration/embedding. The basic idea is to have all validation >>> problems collected but only fail to build the Mavenproject instance >>> when serious base problems are found (validation level minimal). >>> >>> See http://jira.codehaus.org/browse/MNG-5306 for details and links to >>> patch. I haven't submitted to maven codebase for a while so I'd like >>> to have a review before integrating, Thanks. >>> >>> Milos Kleint >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> For additional commands, e-mail: dev-h...@maven.apache.org >>> >> >> >> >> -- >> Olivier Lamy >> Talend: http://coders.talend.com >> http://twitter.com/olamy | http://linkedin.com/in/olamy >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > -- Olivier Lamy Talend: http://coders.talend.com http://twitter.com/olamy | http://linkedin.com/in/olamy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
