> On July 10, 2013, 7:25 p.m., Ben Mahler wrote: > > Was there a rendering issue? Would users know why a dash is present there? > > Ultimately, it would be awesome if we can make it clear that they haven't > > specified the --cluster flag in the master. > > > > What if we add a hover that mentions the --cluster flag? We could display > > "(unnamed cluster)" or the like..
It looked odd having empty space to the right of "Cluster:" when --cluster was not used. I like your idea of a more meaningful default than '-' though with maybe a tooltip mentioning the use of the --cluster flag. I will make some changes. - Ross ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12394/#review22967 ----------------------------------------------------------- On July 10, 2013, 2:06 a.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12394/ > ----------------------------------------------------------- > > (Updated July 10, 2013, 2:06 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Print a dash character, '-', when a resource has no cluster. Right now it > renders blank space. > > > Diffs > ----- > > src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1 > src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d > src/webui/master/static/slave_executor.html > cf3d9567c701f074ba2b1e50467d3fddd3ed5014 > > Diff: https://reviews.apache.org/r/12394/diff/ > > > Testing > ------- > > Rendered each page with a potentially blank cluster. > > > Thanks, > > Ross Allen > >
