> On July 12, 2013, 9:52 p.m., Ben Mahler wrote: > > src/webui/master/static/home.html, line 30 > > <https://reviews.apache.org/r/12394/diff/2/?file=320943#file320943line30> > > > > Can you mention that this is a flag on the master? Having this on the > > slave pages might lead some to think it's a slave flag. > > > > E.g. > > > > "To name this cluster, set the --cluster flag when starting the master." > > Ross Allen wrote: > Can do.
Ben, do you mind committing this for me? The change you requested is in this diff now and ready to roll. - Ross ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12394/#review23100 ----------------------------------------------------------- On July 12, 2013, 10:17 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12394/ > ----------------------------------------------------------- > > (Updated July 12, 2013, 10:17 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Print 'Unnamed' with a tooltip explaining the --cluster flag when the flag is > not used. > > > Diffs > ----- > > src/webui/master/static/controllers.js > f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd > src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1 > src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d > src/webui/master/static/slave_executor.html > cf3d9567c701f074ba2b1e50467d3fddd3ed5014 > > Diff: https://reviews.apache.org/r/12394/diff/ > > > Testing > ------- > > Rendered each page with a potentially blank cluster. > > > File Attachments > ---------------- > > Unnamed default state > > https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.18_PM.png > Unnamed hover state > > https://reviews.apache.org/media/uploaded/files/2013/07/12/Screen_Shot_2013-07-12_at_2.34.23_PM.png > > > Thanks, > > Ross Allen > >
