> On July 15, 2013, 7:30 p.m., Ben Mahler wrote:
> > Can you provide some context for the use of '=' vs ':' in the resource
> > strings?
> >
> > "cpus=45.55 (*); ports=[10000-20000, 30000-50000] (*); disks={sda1} (*)"
> >
> > vs.
> >
> > "cpus:45.55 (*); ports:[10000-20000, 30000-50000] (*); disks:{sda1} (*)"
>
> Thomas Marshall wrote:
> We were merging the parse and stringify formats - parse used ':' and
> stringify used '='. The choice of ':' was arbitrary, and I'm certainly open
> to arguments about why one would be better than the other.
>
> Thomas Marshall wrote:
> It occurs to me - an argument in favor of keeping it ':' is that people
> who are specifying --resources to the slave won't have to change the format.
That's a good point, we should keep it as ':'. What about other formats for the
role? We should carefully consider the format as it's going to be very
difficult to change it once released! ;)
Current:
(1) cpus=4 (*); cpus=8 (jenkins); memory=10GB (*); memory=20GB (jenkins)
How about:
(2) cpus(*):4; cpus(jenkins):8; memory(*):10GB; memory(jenkins):20GB
I would suggest 2 (benh is in agreement on this), should be easier to parse as
well (using strings::split) :)
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12341/#review23169
-----------------------------------------------------------
On July 15, 2013, 10:23 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12341/
> -----------------------------------------------------------
>
> (Updated July 15, 2013, 10:23 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-505
> https://issues.apache.org/jira/browse/MESOS-505
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds parsing of roles to the Resources class. Also updates parse to return a
> Try, in the case that parsing fails, and adds tests for role parsing and for
> Resources operators in the presence of roles.
>
>
> Diffs
> -----
>
> src/common/resources.hpp 42dfb6a
> src/common/resources.cpp 8bc1057
> src/master/drf_sorter.cpp 510acc3
> src/slave/slave.cpp 9a2c671
> src/tests/gc_tests.cpp 1745800
> src/tests/master_tests.cpp 5ac4d5f
> src/tests/resource_offers_tests.cpp beab2d8
> src/tests/resources_tests.cpp 67a11b3
> src/tests/slave_recovery_tests.cpp b0843d7
> src/tests/sorter_tests.cpp 619e786
>
> Diff: https://reviews.apache.org/r/12341/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Thomas Marshall
>
>
