----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12341/#review23401 -----------------------------------------------------------
Ship it! Cool. src/common/resources.cpp <https://reviews.apache.org/r/12341/#comment47268> s/mismatches/mismatched/ src/slave/slave.cpp <https://reviews.apache.org/r/12341/#comment47267> The other convention we have is to use the function name: s/resources_/parse/. This "reads" pretty clearly too ("CHECK_SOME checks that the parse did not error and 'parse.get' returns the result of parse). src/tests/resources_tests.cpp <https://reviews.apache.org/r/12341/#comment47266> s/RemoveRoles/FlattenRoles/ - Benjamin Hindman On July 18, 2013, 12:25 a.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12341/ > ----------------------------------------------------------- > > (Updated July 18, 2013, 12:25 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-505 > https://issues.apache.org/jira/browse/MESOS-505 > > > Repository: mesos > > > Description > ------- > > Adds parsing of roles to the Resources class. Also updates parse to return a > Try, in the case that parsing fails, and adds tests for role parsing and for > Resources operators in the presence of roles. > > > Diffs > ----- > > src/common/resources.hpp 42dfb6a > src/common/resources.cpp 8bc1057 > src/master/drf_sorter.cpp 510acc3 > src/slave/slave.cpp 9a2c671 > src/tests/gc_tests.cpp 1745800 > src/tests/master_tests.cpp 5ac4d5f > src/tests/resource_offers_tests.cpp beab2d8 > src/tests/resources_tests.cpp 67a11b3 > src/tests/slave_recovery_tests.cpp b0843d7 > src/tests/sorter_tests.cpp 619e786 > > Diff: https://reviews.apache.org/r/12341/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
