----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12800/#review23603 -----------------------------------------------------------
Ship it! What caused this one? Was this because Jenkins tried to start calling in to our code prior to us having started the scheduler? If so, is there a way for us to postpone creating any MesosComputerLaunchers until we've started the scheduler? A TODO would be fine :) jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosComputerLauncher.java <https://reviews.apache.org/r/12800/#comment47508> s/ndoe/node/ jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosComputerLauncher.java <https://reviews.apache.org/r/12800/#comment47509> How about: "the Mesos Jenkins scheduler" Or something that indicates that this is owned by this framework rather than part of Jenkins. "Jenkins scheduler" may sound like it is part of the Jenkins project. - Ben Mahler On July 21, 2013, 8:38 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12800/ > ----------------------------------------------------------- > > (Updated July 21, 2013, 8:38 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosComputerLauncher.java > dc3bf8e0b824dd2cab460a9888a497ba2d551267 > > Diff: https://reviews.apache.org/r/12800/diff/ > > > Testing > ------- > > mvn hpi:run > > > Thanks, > > Vinod Kone > >
