> On July 22, 2013, 12:10 a.m., Ben Mahler wrote: > > What caused this one? Was this because Jenkins tried to start calling in to > > our code prior to us having started the scheduler? If so, is there a way > > for us to postpone creating any MesosComputerLaunchers until we've started > > the scheduler? A TODO would be fine :)
Jenkins persists state between invocations. So, if some slaves were offline in the previous invocation, when Jenkins starts up its tries to launch them. Added a comment. > On July 22, 2013, 12:10 a.m., Ben Mahler wrote: > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosComputerLauncher.java, > > line 46 > > <https://reviews.apache.org/r/12800/diff/1/?file=324263#file324263line46> > > > > s/ndoe/node/ thanks! - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12800/#review23603 ----------------------------------------------------------- On July 21, 2013, 8:38 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12800/ > ----------------------------------------------------------- > > (Updated July 21, 2013, 8:38 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosComputerLauncher.java > dc3bf8e0b824dd2cab460a9888a497ba2d551267 > > Diff: https://reviews.apache.org/r/12800/diff/ > > > Testing > ------- > > mvn hpi:run > > > Thanks, > > Vinod Kone > >
