> On July 21, 2013, 11:59 p.m., Ben Mahler wrote: > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosRetentionStrategy.java, > > lines 30-31 > > <https://reviews.apache.org/r/12797/diff/2/?file=324261#file324261line30> > > > > Hm.. what does being disabled entail? Maybe a comment if you happen to > > know? Should the check() function should bail immediately if disabled?
actually no clue. i'm going to kill it. > On July 21, 2013, 11:59 p.m., Ben Mahler wrote: > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosRetentionStrategy.java, > > line 34 > > <https://reviews.apache.org/r/12797/diff/2/?file=324261#file324261line34> > > > > I'm a little fuzzy on the wiring here, is this argument coming from the > > webui? yes, fwict. src/main/resources/org/jenkinsci/plugins/mesos/MesosSlave/configure-entries.jelly > On July 21, 2013, 11:59 p.m., Ben Mahler wrote: > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosRetentionStrategy.java, > > line 50 > > <https://reviews.apache.org/r/12797/diff/2/?file=324261#file324261line50> > > > > Does this comment match the code? It looks more like: > > > > // If the computer just connected, check back later. > > > > Is that what you intended? despite the bad naming, connectTime is set when a slave is launched. > On July 21, 2013, 11:59 p.m., Ben Mahler wrote: > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosRetentionStrategy.java, > > line 60 > > <https://reviews.apache.org/r/12797/diff/2/?file=324261#file324261line60> > > > > Does c.isOffline() imply c.isIdle()? That's what this code assumes, but > > I can't tell if it's true from the javadocs. good catch. i'm not sure either. fixed it anyway. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12797/#review23601 ----------------------------------------------------------- On July 21, 2013, 7:34 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12797/ > ----------------------------------------------------------- > > (Updated July 21, 2013, 7:34 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosRetentionStrategy.java > e02d3c7d4cd832b855de17e002976db64ec89752 > > Diff: https://reviews.apache.org/r/12797/diff/ > > > Testing > ------- > > mvn hpi:run > > > Thanks, > > Vinod Kone > >
