----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12797/#review23643 -----------------------------------------------------------
Ship it! jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosRetentionStrategy.java <https://reviews.apache.org/r/12797/#comment47540> s/Mesos node/Mesos task/ ? jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosRetentionStrategy.java <https://reviews.apache.org/r/12797/#comment47541> Can you add a comment that despite the name, connectTime refers to the time at which we *launched* the computer, rather than the time that it started and connected to jenkins? That still seems really surprising to me if it's true. jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosRetentionStrategy.java <https://reviews.apache.org/r/12797/#comment47544> Something like: s/a long time/longer than the timeout/ - Ben Mahler On July 22, 2013, 2:16 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12797/ > ----------------------------------------------------------- > > (Updated July 22, 2013, 2:16 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosRetentionStrategy.java > e02d3c7d4cd832b855de17e002976db64ec89752 > > Diff: https://reviews.apache.org/r/12797/diff/ > > > Testing > ------- > > mvn hpi:run > > > Thanks, > > Vinod Kone > >
