----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11131/#review23670 -----------------------------------------------------------
This looks good! Just some small cleanup below. src/linux/cgroups.cpp <https://reviews.apache.org/r/11131/#comment47566> I think we can kill the VLOG, unless you think it will be useful? These processes could go away during normal operation so it doesn't seem like a failure. src/linux/cgroups.cpp <https://reviews.apache.org/r/11131/#comment47567> Update the comment? src/linux/cgroups.cpp <https://reviews.apache.org/r/11131/#comment47568> LGTM! Hopefully the freezer becomes more stable over time, and we can use it reliably =/ - Ben Mahler On June 17, 2013, 7:36 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11131/ > ----------------------------------------------------------- > > (Updated June 17, 2013, 7:36 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Changed cgroups killTasks() sequence. > > The sequence is as follows: > stop -> kill -> empty -> freeze -> kill -> thaw -> empty > > We also now ignore ESRCH errors from kill() in cgroups::kill(). > > Review: https://reviews.apache.org/r/11131 > > > Diffs > ----- > > src/linux/cgroups.cpp 8d94fe63610c4c7a48f92d260fcd526b7a83942e > > Diff: https://reviews.apache.org/r/11131/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
