----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11131/#review23732 -----------------------------------------------------------
Ship it! Modulo comments below. src/linux/cgroups.cpp <https://reviews.apache.org/r/11131/#comment47608> s/kill/signal/ src/linux/cgroups.cpp <https://reviews.apache.org/r/11131/#comment47609> 3 parts? How about: // The sequence of operations to kill a cgroup is as follows: // SIGSTOP -> SIGKILL -> empty -> freeze -> SIGKILL -> thaw -> empty // This process is repeated until the cgroup becomes empty. - Ben Mahler On July 23, 2013, 9:47 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11131/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 9:47 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Changed cgroups killTasks() sequence. > > The sequence is as follows: > stop -> kill -> empty -> freeze -> kill -> thaw -> empty > > We also now ignore ESRCH errors from kill() in cgroups::kill(). > > Review: https://reviews.apache.org/r/11131 > > > Diffs > ----- > > src/linux/cgroups.cpp 5207ded352b0f6ce7922d59d6b47f2dd1a71538d > > Diff: https://reviews.apache.org/r/11131/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
