> On June 27, 2013, 7:07 p.m., Ben Mahler wrote: > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, lines > > 452-453 > > <https://reviews.apache.org/r/11130/diff/7/?file=311244#file311244line452> > > > > Include the overhead in the default computation. To get the heap value > > you would subtract the overhead from slotMem (as done previously). > > > > This is because 'cpus', 'disk', and 'mem' are the raw resources > > allocated by mesos, so it would be nice to keep that meaning consistent. We > > could hide 'mem' and introduce 'heap', 'jvm_overhead', etc, should the need > > arise later.
I'm not sure I understand why you raised this as an issue. What's there to change here? As far as I can tell, it behaves as you describe. > On June 27, 2013, 7:07 p.m., Ben Mahler wrote: > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, lines > > 457-460 > > <https://reviews.apache.org/r/11130/diff/7/?file=311244#file311244line457> > > > > I think we want to keep the overhead as part of the default > > computation. So that 'mem' continues to mean the resources allocated by > > mesos. > > > > Also, we should add a default value in mapred-site.xml for this new > > knob. Explaining that 10% of 'mem' is used as overhead for the JVM. > > > > As you said, we may need to expose the overhead percent knob, but let's > > hope not! :) See comment above. - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11130/#review22479 ----------------------------------------------------------- On June 26, 2013, 8:20 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11130/ > ----------------------------------------------------------- > > (Updated June 26, 2013, 8:20 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Allow some JVM memory vars to be configured. > > Review: https://reviews.apache.org/r/11130 > > > Diffs > ----- > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java > c5a63bc7a172c44cc11d6bdd6b2eb4bc3df35cb7 > > Diff: https://reviews.apache.org/r/11130/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
