> On July 25, 2013, 12:26 a.m., Vinod Kone wrote: > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, lines > > 453-454 > > <https://reviews.apache.org/r/11130/diff/8/?file=327647#file327647line453> > > > > how about > > > > Math.round((1-JVM_MEM_OVERHEAD_PERCENT_DEFAULT)) * slotMem > > > > same for taskTrackerMem below?
I did this in a later commit. - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11130/#review23802 ----------------------------------------------------------- On July 25, 2013, 1:27 a.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11130/ > ----------------------------------------------------------- > > (Updated July 25, 2013, 1:27 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Allowed some JVM memory vars to be configured. > > Also modified the slot CPU/mem values to be more sane defaults. > > Review: https://reviews.apache.org/r/11130 > > > Diffs > ----- > > hadoop/mapred-site.xml.patch 8b3997944f60a9d91c81089a4450e4820526dde3 > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java > 279f84e0f0c43ad3cfd9e4442010e706ee3565d9 > > Diff: https://reviews.apache.org/r/11130/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
