> On July 25, 2013, 9:05 p.m., Ben Mahler wrote:
> > src/webui/master/static/browse.html, lines 42-43
> > <https://reviews.apache.org/r/12887/diff/1/?file=326197#file326197line42>
> >
> > Looks a bit odd that some are right aligned, and some are left aligned
> > IMO, was this the cleanest look?
>
> Ross Allen wrote:
> I was sticking to the layout of `ls`. I think the mtime column is
> justified rather than aligned, but otherwise the right/left alignment matches
> `ls`.
Ah, I should have clarified that I was referring to the table headers only, I
think the columns are ok, is it possible to have the titles all right aligned
over the column text?
Right Title
Left Aligned Body
Either way, looks good!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12887/#review23865
-----------------------------------------------------------
On July 24, 2013, 12:14 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12887/
> -----------------------------------------------------------
>
> (Updated July 24, 2013, 12:14 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Style /browse to distinguish folders
>
> * Add small folder icons to the left of folders to distinguish them
> from other files.
> * Right align Size, Nlink, and mtime columns.
> * Remove 'name' title since it is apparent
> * Order files first by file type, i.e. folder or not folder, and then
> by name.
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html
> 366e99978554916feb7be962d4f1df8fd93773cc
>
> Diff: https://reviews.apache.org/r/12887/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Pre-commit browse
>
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.13.32_PM.png
> Post-commit browse
>
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.09.23_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
