> On July 25, 2013, 9:05 p.m., Ben Mahler wrote: > > src/webui/master/static/browse.html, lines 42-43 > > <https://reviews.apache.org/r/12887/diff/1/?file=326197#file326197line42> > > > > Looks a bit odd that some are right aligned, and some are left aligned > > IMO, was this the cleanest look? > > Ross Allen wrote: > I was sticking to the layout of `ls`. I think the mtime column is > justified rather than aligned, but otherwise the right/left alignment matches > `ls`. > > Ben Mahler wrote: > Ah, I should have clarified that I was referring to the table headers > only, I think the columns are ok, is it possible to have the titles all right > aligned over the column text? > > Right Title > Left Aligned Body > > Either way, looks good!
Check out the screenshots I just attached. Having the headers all right-aligned with some left-aligned content makes it difficult to tell which header belongs to which column. I think it makes sense to have the header aligned the same as the column content. - Ross ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12887/#review23865 ----------------------------------------------------------- On July 26, 2013, 6:57 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12887/ > ----------------------------------------------------------- > > (Updated July 26, 2013, 6:57 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Style /browse to distinguish folders > > * Add small folder icons to the left of folders to distinguish them > from other files. > * Right align Size, Nlink, and mtime columns. > * Remove 'name' title since it is apparent > * Order files first by file type, i.e. folder or not folder, and then > by name. > > > Diffs > ----- > > src/webui/master/static/browse.html > 366e99978554916feb7be962d4f1df8fd93773cc > > Diff: https://reviews.apache.org/r/12887/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Pre-commit browse > > https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.13.32_PM.png > Post-commit browse > > https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.09.23_PM.png > Right-aligned headers > > https://reviews.apache.org/media/uploaded/files/2013/07/26/Screen_Shot_2013-07-26_at_11.56.18_AM.png > Headers aligned same as column > > https://reviews.apache.org/media/uploaded/files/2013/07/26/Screen_Shot_2013-07-26_at_11.56.25_AM.png > > > Thanks, > > Ross Allen > >
