----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12436/#review23998 -----------------------------------------------------------
Cool! Looking forward for ProcessTree and a better os::killtree! 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp <https://reviews.apache.org/r/12436/#comment47812> s/Faild/Failed/ 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp <https://reviews.apache.org/r/12436/#comment47818> Why not conditionally adding to groups / sessions? i.e. if (groups) { visited.groups.insert(parent.get().group); } if (sessions) { visited.sessions.insert(parent.get().group); } 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp <https://reviews.apache.org/r/12436/#comment47816> This doesn't look like standard BFS, why did you have to add the check here? 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp <https://reviews.apache.org/r/12436/#comment47815> See my comment above, without dosetsid, would this test pass? 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp <https://reviews.apache.org/r/12436/#comment47813> Nice comment! - Ben Mahler On July 12, 2013, 1:28 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12436/ > ----------------------------------------------------------- > > (Updated July 12, 2013, 1:28 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > * Uses a static "view" of the processes (less system calls and less volatile > semantics). > > * Doesn't include processes from the parent group or session (unless they are > in the tree). > > * Returns a list of process trees instead of outputing the different > processes encountered (the process trees can be stringified). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp > 2a0f01a7e23d66dc5852f82e81ea9be60778ef04 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 6a11b018f83651be20026850aeb7cf08d7c85b2f > > Diff: https://reviews.apache.org/r/12436/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
