> On July 27, 2013, 12:55 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 399 > > <https://reviews.apache.org/r/12436/diff/2/?file=320717#file320717line399> > > > > See my comment above, without dosetsid, would this test pass?
This still walks all the children. > On July 27, 2013, 12:55 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp, lines > > 88-90 > > <https://reviews.apache.org/r/12436/diff/2/?file=320715#file320715line88> > > > > This doesn't look like standard BFS, why did you have to add the check > > here? True. The alternative is checking before every insert ... I'm indifferent here I was just trying to eliminate some redundant code. Preference? > On July 27, 2013, 12:55 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp, lines > > 72-73 > > <https://reviews.apache.org/r/12436/diff/2/?file=320715#file320715line72> > > > > Why not conditionally adding to groups / sessions? > > > > i.e. > > > > if (groups) { > > visited.groups.insert(parent.get().group); > > } > > if (sessions) { > > visited.sessions.insert(parent.get().group); > > } Sounds good. > On July 27, 2013, 12:55 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp, line 54 > > <https://reviews.apache.org/r/12436/diff/2/?file=320715#file320715line54> > > > > s/Faild/Failed/ Thanks! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12436/#review23998 ----------------------------------------------------------- On July 12, 2013, 1:28 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12436/ > ----------------------------------------------------------- > > (Updated July 12, 2013, 1:28 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > * Uses a static "view" of the processes (less system calls and less volatile > semantics). > > * Doesn't include processes from the parent group or session (unless they are > in the tree). > > * Returns a list of process trees instead of outputing the different > processes encountered (the process trees can be stringified). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp > 2a0f01a7e23d66dc5852f82e81ea9be60778ef04 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 6a11b018f83651be20026850aeb7cf08d7c85b2f > > Diff: https://reviews.apache.org/r/12436/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
