----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12885/#review24278 -----------------------------------------------------------
Ship it! src/master/flags.hpp <https://reviews.apache.org/r/12885/#comment48113> I don't think we parse 's', you need all of 'secs'. Also, please kill the whitespace at the beginning of the continuing lines. src/master/master.cpp <https://reviews.apache.org/r/12885/#comment48111> Let's just pass all of 'flags' in and then read it out like 'flags.slave_ping_timeout'. It's more obvious when doing it like that where this value came from. Also, we put '&' next to the type. If you really don't want to pass flags then please s/slave_ping_timeout/slavePingTimeout/. I know, it's a drag, but we only name our flag variables with underscores to have consistency with the command line arguments. Feel free to take on a complete rename of all variables in Mesos to go from camel case to snake case ... I don't think anyone will fight you! src/master/master.cpp <https://reviews.apache.org/r/12885/#comment48110> Please do this check in Master::initialize and do an EXIT(1) there. src/master/master.cpp <https://reviews.apache.org/r/12885/#comment48112> So, 'flags.slave_ping_timeout'. - Benjamin Hindman On July 23, 2013, 11:42 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12885/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 11:42 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Slave ping timeout may be increased by flags. > > Review: https://reviews.apache.org/r/12885 > > > Diffs > ----- > > src/master/constants.hpp f3a95f1006472ff2b90cabb8cf74182830740954 > src/master/constants.cpp 7bc32eb3bdae717ded63436e47031934384eec23 > src/master/flags.hpp 6dbbb79d447991a4929fe27628961c0874adadf8 > src/master/master.cpp e4507acd97ebaf2ce693ec7343e9a4a563f6ff80 > src/tests/fault_tolerance_tests.cpp > c8d88d5f60cf49ef5c1ffa429d308c30c2e5005c > > Diff: https://reviews.apache.org/r/12885/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Brenden Matthews > >
