> On July 30, 2013, 7:47 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 145-151 > > <https://reviews.apache.org/r/12885/diff/1/?file=326194#file326194line145> > > > > Instead of overriding implicitly, can you change this to use EXIT(1)? > > > > EXIT(1) << "..."; > > > > It would be better to be explicit about the fact that their flag value > > is invalid. > > Brenden Matthews wrote: > I would also suggest using EXIT_FAILURE instead of 1/0, but I'll go with > the existing convention.
SGTM! Want to create a JIRA issue to replace all EXIT(*) with EXIT(EXIT_FAILURE)? Or maybe better would be an empty EXIT() which uses EXIT_FAILURE? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12885/#review24273 ----------------------------------------------------------- On July 30, 2013, 10:02 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12885/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 10:02 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Slave ping timeout may be increased by flags. > > Review: https://reviews.apache.org/r/12885 > > > Diffs > ----- > > src/master/constants.hpp f3a95f1006472ff2b90cabb8cf74182830740954 > src/master/constants.cpp 7bc32eb3bdae717ded63436e47031934384eec23 > src/master/flags.hpp 6dbbb79d447991a4929fe27628961c0874adadf8 > src/master/master.cpp e4507acd97ebaf2ce693ec7343e9a4a563f6ff80 > src/tests/fault_tolerance_tests.cpp > c8d88d5f60cf49ef5c1ffa429d308c30c2e5005c > > Diff: https://reviews.apache.org/r/12885/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Brenden Matthews > >
