-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13087/
-----------------------------------------------------------
(Updated Aug. 1, 2013, 7:31 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
- Added a StandaloneMasterDetector which makes it explicit that this detector
requires someone to appoint a leader for the detection.
- Class MasterDetector becomes abstract.
- Master no longer appoint()s itself blindly in its initialize(), the main.cpp
does it when it knows that it's the StandaloneMasterDetector.
Bugs: MESOS-496
https://issues.apache.org/jira/browse/MESOS-496
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/scheduler.hpp 1a7fcb9656a8f13d603cffeec9eb0f3c7aade05b
src/Makefile.am 15a9c4046fd21bf9ff6c6e2d31ddb93386618cfa
src/detector/detector.hpp b0e66888050c1987b7200cdbf21ebe5e2e55e6c0
src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e
src/local/local.cpp 3364c15f6b2374d752e83eb8a1c3c49de6bcc259
src/local/main.cpp 5995c538077dea301f231668b4b5f905e73e7b3b
src/master/contender.hpp PRE-CREATION
src/master/contender.cpp PRE-CREATION
src/master/detector.hpp PRE-CREATION
src/master/detector.cpp PRE-CREATION
src/master/http.cpp a114462e15bc61da3178dba6bf40d32b4b7b55fa
src/master/main.cpp 19fcb9f09d8fc03a0719aada7d216b575eb3069b
src/master/master.hpp bdaf4d64c0ecdaf4539b9d13b2e3751f5731c0aa
src/master/master.cpp e4507acd97ebaf2ce693ec7343e9a4a563f6ff80
src/messages/messages.proto 19d4b387b50884f9f4a70efb3e9b739f846abf57
src/sched/sched.cpp 62abd38447ad32ccc64e542d42b7d45f62816714
src/slave/http.cpp b7d1582969e836eb040dd98e28a05b2f6044c8d3
src/slave/main.cpp 750a12766bde64059bfd4635ea077cbd43cb4301
src/slave/slave.hpp 5a0fdd92529e85fbea2a3591b2c731182b736404
src/slave/slave.cpp 54eaf8f5db47ff481b0590d214746cec63581680
src/tests/allocator_tests.cpp c57da6eb3c431b47468b6a6941c3de06af9209e5
src/tests/cluster.hpp f743bb3251af81fb9d8afd51de4df6efcf289bb9
src/tests/fault_tolerance_tests.cpp c8d88d5f60cf49ef5c1ffa429d308c30c2e5005c
src/tests/gc_tests.cpp e404de3bfacfcac5515995f1b45c3d39181e138f
src/tests/isolator_tests.cpp cd3b3000060b379ef10e38a2a98a2eebe69d90fc
src/tests/master_contender_detector_tests.cpp PRE-CREATION
src/tests/master_detector_tests.cpp 2d140ba1a364a7af4d643951d6016ac17dd10526
src/tests/master_tests.cpp 4c0666e30fdbf36755e6ad346adea0e26fd887f0
src/tests/mesos.hpp 8fbd56c8dd438a08673b54630bfe25d60ad5ee0e
src/tests/mesos.cpp 776cb0f13d10b4ae437fe9a3c97dc8b3481290af
src/tests/slave_recovery_tests.cpp 1871e3ba41e65dcbd4b95779dda068f6a1a2ecb3
src/tests/zookeeper_tests.cpp 16c5fb7daaf684ece5542b42dd9e9ec66f4a41ce
Diff: https://reviews.apache.org/r/13087/diff/
Testing (updated)
-------
make check 100 times
Thanks,
Jiang Yan Xu
