----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13087/#review26992 -----------------------------------------------------------
partial review. include/mesos/scheduler.hpp <https://reviews.apache.org/r/13087/#comment52555> Reorder. src/local/local.cpp <https://reviews.apache.org/r/13087/#comment52556> s/At/NOTE: At/ ? src/master/contender.hpp <https://reviews.apache.org/r/13087/#comment52557> s/of// What do you mean by "with a basic implementation" ? src/master/contender.hpp <https://reviews.apache.org/r/13087/#comment52564> s/on/using/ src/master/contender.hpp <https://reviews.apache.org/r/13087/#comment52563> This seems weird. Why can't we have a BasicMasterDetector like we do ZooKeeperMasterDetector? src/master/contender.hpp <https://reviews.apache.org/r/13087/#comment52558> s/has/it has/ src/master/contender.hpp <https://reviews.apache.org/r/13087/#comment52559> s/calller/caller/ src/master/contender.hpp <https://reviews.apache.org/r/13087/#comment52560> s/is watching/and watching/ src/master/contender.hpp <https://reviews.apache.org/r/13087/#comment52561> Are there cases when it cannot be ignored? How do the users of this API differentiate them? src/master/contender.hpp <https://reviews.apache.org/r/13087/#comment52562> Pull this up close to other forward declarations. src/master/contender.cpp <https://reviews.apache.org/r/13087/#comment52565> reorder - Vinod Kone On Oct. 14, 2013, 11:30 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13087/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2013, 11:30 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, > and Vinod Kone. > > > Bugs: MESOS-496 > https://issues.apache.org/jira/browse/MESOS-496 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/scheduler.hpp 4c042166e0a600ca6131d364388d8a9f20f25efb > src/Makefile.am a2d82425f74dcaf3adf28ae8184fff53b3c34ceb > src/detector/detector.hpp b0e66888050c1987b7200cdbf21ebe5e2e55e6c0 > src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e > src/local/local.cpp e4b5ec5b3dfae6dd89746353d3caaa8d7e117840 > src/local/main.cpp 5995c538077dea301f231668b4b5f905e73e7b3b > src/master/contender.hpp PRE-CREATION > src/master/contender.cpp PRE-CREATION > src/master/detector.hpp PRE-CREATION > src/master/detector.cpp PRE-CREATION > src/master/http.cpp f2a535a002f07784db724f6fdedfb26b271d6327 > src/master/main.cpp 19fcb9f09d8fc03a0719aada7d216b575eb3069b > src/master/master.hpp 9f5e25b2f67efd85090cfd0f8bcc916cd6751cbf > src/master/master.cpp 1bf5d47b2894a896ef7ee0cec05170dff86b62e8 > src/messages/messages.proto a5dded2c0f3f88a5f7d789ccde6e59f68880374b > src/sched/sched.cpp 824b4b750511475c111be6e3fc5f5461448b3045 > src/slave/http.cpp 62fbb37a1924062543bf9db4229704bdef91601d > src/slave/main.cpp 750a12766bde64059bfd4635ea077cbd43cb4301 > src/slave/slave.hpp 22fb74b71a0f52d9d67b92ecc286fa8d350e41a4 > src/slave/slave.cpp debb2f4ce05fbfec450197e68bc8a0c78f1d0adf > src/tests/allocator_tests.cpp 49fad2df7af08211c9306d0c56bffd4f8c253a15 > src/tests/authentication_tests.cpp 48a9323d03416ad9ee25fc19838d89678ff613bc > src/tests/cluster.hpp f743bb3251af81fb9d8afd51de4df6efcf289bb9 > src/tests/fault_tolerance_tests.cpp > 198161a17cb96d93d3b49c1b56bbcf288f0f1bed > src/tests/gc_tests.cpp 375f762c5a9537f87e094f66a933257f6eb267bd > src/tests/isolator_tests.cpp ab5b00aa7f12dbd299debc1a405ac50c59cec85c > src/tests/master_contender_detector_tests.cpp PRE-CREATION > src/tests/master_tests.cpp feea541c62eac4ff879ff78f6b143cc075ca4a09 > src/tests/mesos.hpp 4358c8679907ce5050aafa6f552b2418f0ff12ba > src/tests/mesos.cpp 535ee974ac8a6b1d71e3802a4873d3759555116d > src/tests/slave_recovery_tests.cpp 4d262c65043ad86e0851ac816092f6e8b468a114 > src/tests/zookeeper_tests.cpp 16c5fb7daaf684ece5542b42dd9e9ec66f4a41ce > > Diff: https://reviews.apache.org/r/13087/diff/ > > > Testing > ------- > > make check 100 times > > > Thanks, > > Jiang Yan Xu > >
