----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13508/#review25083 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/13508/#comment49271> Can you make this a TODO given it's a short term hack? What is the long term solution? Can you add that to the comment, or add a mention that we need to revisit this once we have... the registrar? src/master/master.cpp <https://reviews.apache.org/r/13508/#comment49272> Can you add a using std::tr1::shared_ptr at the top of master.cpp and then declare this on one line: >>> len(' foreach (const std::tr1::shared_ptr<Framework>& framework, completedFrameworks) {') 83 >>> len(' foreach (const shared_ptr<Framework>& framework, completedFrameworks) {') 73 src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13508/#comment49263> 2 spaces src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13508/#comment49266> EXPECT_FALSE(offers.get().empty()); ? src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13508/#comment49267> Can you move this down to before the launchTasks call where 'tasks' is used? - Ben Mahler On Aug. 12, 2013, 10:05 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13508/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2013, 10:05 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-633 > https://issues.apache.org/jira/browse/MESOS-633 > > > Repository: mesos-git > > > Description > ------- > > This handles the case when the ShutdownFramework message isn't received by > the slave (e.g., disconnected, partitioned). > > > Diffs > ----- > > src/master/master.cpp a2f8929987f95e796aba71063223aea7003bf3df > src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8 > > Diff: https://reviews.apache.org/r/13508/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
