> On Aug. 13, 2013, 6:32 p.m., Ben Mahler wrote: > > src/tests/slave_recovery_tests.cpp, line 1645 > > <https://reviews.apache.org/r/13508/diff/1/?file=340253#file340253line1645> > > > > EXPECT_FALSE(offers.get().empty()); ?
For consistency with all the other tests, I will leave it as is. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13508/#review25083 ----------------------------------------------------------- On Aug. 12, 2013, 10:05 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13508/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2013, 10:05 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-633 > https://issues.apache.org/jira/browse/MESOS-633 > > > Repository: mesos-git > > > Description > ------- > > This handles the case when the ShutdownFramework message isn't received by > the slave (e.g., disconnected, partitioned). > > > Diffs > ----- > > src/master/master.cpp a2f8929987f95e796aba71063223aea7003bf3df > src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8 > > Diff: https://reviews.apache.org/r/13508/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
