----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13401/#review25172 -----------------------------------------------------------
Ship it! Can you also add the bug ID to the review? src/slave/slave.cpp <https://reviews.apache.org/r/13401/#comment49438> Instead of iterating, we should use stout/cache.hpp to store them instead of a circular buffer (now that we want to do a quick lookup). But you will need to add a removal operation to cache. Either of the following are fine with me: size_type erase(const Key& key); // Allows you to get and remove in one call. Option<Value> remove(const Key& key); Feel free to simply punt and leave a TODO for later though! Just commenting on this as a note for posterity. - Ben Mahler On Aug. 8, 2013, 2:57 a.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13401/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2013, 2:57 a.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Fixed handling of executor history on slaves. > > This resolves https://issues.apache.org/jira/browse/MESOS-616. > > Review: https://reviews.apache.org/r/13401 > > > Diffs > ----- > > src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac > > Diff: https://reviews.apache.org/r/13401/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Brenden Matthews > >
