----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13401/#review25187 -----------------------------------------------------------
Hey Brenden, do you mind committing the *previous* diff (with our Ship Its) with an added TODO? We can take on the cache changes in a separate review. :) - Ben Mahler On Aug. 14, 2013, 9:28 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13401/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2013, 9:28 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-616 > https://issues.apache.org/jira/browse/MESOS-616 > > > Repository: mesos-git > > > Description > ------- > > Fixed handling of executor history on slaves. > > The list of retired (completed) frameworks is now a stout cache rather > than a boost circular buffer. There are now key iterator accessors for > the cache class, and a removal member. > > This resolves https://issues.apache.org/jira/browse/MESOS-616. > > Review: https://reviews.apache.org/r/13401 > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp > 653507c5f1293acb929d2ffa33738fd830541c84 > src/slave/http.cpp 073d0923febf697dec2a9bbfa6e3b243bcab7316 > src/slave/slave.hpp ef8b64f952b7335b7f20f6c69e49450eecf563ce > src/slave/slave.cpp cf9f2923fe0e854d457519d700acc951279e1bba > > Diff: https://reviews.apache.org/r/13401/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Brenden Matthews > >
