----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13698/#review25361 -----------------------------------------------------------
you should also change the checkpointing done inside status update manager. please make sure you catch all the checkpoints by doing a grep, if you haven't already. src/launcher/launcher.cpp <https://reviews.apache.org/r/13698/#comment49751> s/forked/executor's forked/ src/launcher/launcher.cpp <https://reviews.apache.org/r/13698/#comment49750> s/forked/executor's forked/ maybe include executor id ince you are not including the path here? src/slave/state.cpp <https://reviews.apache.org/r/13698/#comment49757> This should be moved to where we do checkpointing in the launcher. - Vinod Kone On Aug. 21, 2013, 2:59 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13698/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2013, 2:59 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See above. > > > Diffs > ----- > > src/launcher/launcher.cpp 8d4e53d0b87c4ff6ec591b565d6c67f40b66e073 > src/slave/slave.cpp 92a0a7edb46eb3525e193c81129291e405cebaad > src/slave/state.cpp aab8d0b090c7b821fe55aec640d37d1aab9fe7ed > > Diff: https://reviews.apache.org/r/13698/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
