> On Aug. 21, 2013, 4:19 a.m., Vinod Kone wrote: > > src/slave/state.cpp, lines 551-552 > > <https://reviews.apache.org/r/13698/diff/1/?file=342821#file342821line551> > > > > This should be moved to where we do checkpointing in the launcher.
Removed it but didn't place it in the launcher since it's logging using cerr everywhere and we've also documented it there. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13698/#review25361 ----------------------------------------------------------- On Aug. 21, 2013, 11:07 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13698/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2013, 11:07 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See above. > > > Diffs > ----- > > src/launcher/launcher.cpp 8d4e53d0b87c4ff6ec591b565d6c67f40b66e073 > src/slave/slave.cpp 92a0a7edb46eb3525e193c81129291e405cebaad > src/slave/state.cpp aab8d0b090c7b821fe55aec640d37d1aab9fe7ed > src/slave/status_update_manager.hpp > a032646163c5f930a51c59be2b8cb4a5ef965e0e > > Diff: https://reviews.apache.org/r/13698/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
