----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13709/#review25373 -----------------------------------------------------------
Thanks for the cleanup! Mind change the title to something more descriptive? How about "Fixed typos and added .gitignore"? .gitignore <https://reviews.apache.org/r/13709/#comment49771> Meant to add this to the repo for a while, thanks for taking this up. Since .gitignore looks up files recursively can we just do this? # git .gitignore # build dir build # autotools autom4te.cache Makefile.in configure config.guess config.sub depcomp ar-lib ltmain.sh install-sh missing aclocal.m4 libtool.m4 ltoptions.m4 ltsugar.m4 ltversion.m4 lt~obsolete.m4 src/tests/status_update_manager_tests.cpp <https://reviews.apache.org/r/13709/#comment49772> This is a protobuf enum. Please revert. - Vinod Kone On Aug. 21, 2013, 3:23 p.m., Kevin Lyda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13709/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2013, 3:23 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-654 > https://issues.apache.org/jira/browse/MESOS-654 > > > Repository: mesos-git > > > Description > ------- > > Fixed a few typos, added a .gitignore, removed a generated file. > > > Diffs > ----- > > .gitignore PRE-CREATION > 3rdparty/libprocess/install-sh 6781b98 > README e94531d > src/common/values.cpp ce26119 > src/linux/cgroups.cpp b97a89c > src/log/coordinator.cpp 6e6466f > src/log/log.cpp aea06e7 > src/master/master.cpp d53b8bb > src/slave/slave.cpp 92a0a7e > src/tests/allocator_tests.cpp c57da6e > src/tests/resources_tests.cpp 964a1b6 > src/tests/status_update_manager_tests.cpp cf420e4 > > Diff: https://reviews.apache.org/r/13709/diff/ > > > Testing > ------- > > git clean -fxd > ./bootstrap > cd build > ../configure > make > make check > > All these work as they did before. git status is now clean when the tree is > built (unless there have been code changes made). git diff only shows code > changes, not stuff from generated files. > > > Thanks, > > Kevin Lyda > >
