> On Aug. 21, 2013, 5:41 p.m., Vinod Kone wrote: > > .gitignore, lines 1-43 > > <https://reviews.apache.org/r/13709/diff/1/?file=342936#file342936line1> > > > > Meant to add this to the repo for a while, thanks for taking this up. > > > > Since .gitignore looks up files recursively can we just do this? > > > > # git > > .gitignore > > > > # build dir > > build > > > > # autotools > > autom4te.cache > > Makefile.in > > configure > > config.guess > > config.sub > > depcomp > > ar-lib > > ltmain.sh > > install-sh > > missing > > aclocal.m4 > > libtool.m4 > > ltoptions.m4 > > ltsugar.m4 > > ltversion.m4 > > lt~obsolete.m4 > > Ben Mahler wrote: > FWIW I also have these: > > # Ignore OSX Files > *.DS_Store > > # Eclipse > .project > .cproject > .pydevproject > .settings > > # Compiled python > *.pyc
Disregard my comment, let's commit a platform / tool agnostic version, and make sure we ignore .gitignore so others can add their own touches. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13709/#review25373 ----------------------------------------------------------- On Aug. 21, 2013, 6:13 p.m., Kevin Lyda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13709/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2013, 6:13 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-654 > https://issues.apache.org/jira/browse/MESOS-654 > > > Repository: mesos-git > > > Description > ------- > > Fixed a few typos, added a .gitignore, removed a generated file. > > > Diffs > ----- > > .gitignore PRE-CREATION > 3rdparty/libprocess/install-sh 6781b98 > README e94531d > src/common/values.cpp ce26119 > src/linux/cgroups.cpp b97a89c > src/log/coordinator.cpp 6e6466f > src/log/log.cpp aea06e7 > src/master/master.cpp d53b8bb > src/slave/slave.cpp 92a0a7e > src/tests/allocator_tests.cpp c57da6e > src/tests/resources_tests.cpp 964a1b6 > src/tests/status_update_manager_tests.cpp cf420e4 > > Diff: https://reviews.apache.org/r/13709/diff/ > > > Testing > ------- > > git clean -fxd > ./bootstrap > cd build > ../configure > make > make check > > All these work as they did before. git status is now clean when the tree is > built (unless there have been code changes made). git diff only shows code > changes, not stuff from generated files. > > > Thanks, > > Kevin Lyda > >
