----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13747/#review25447 -----------------------------------------------------------
Ship it! nice test! src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13747/#comment49851> s/ack/_statusUpdateAcknowledgement/ this is the new convention. i know some of the old tests in this file do not follow it yet, but we should clean them up at some point. src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13747/#comment49853> s/recover/_recover/ src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13747/#comment49852> s/reregisterSlave/reregisterSlaveMessage/ src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13747/#comment49854> This should be done in a while loop to ensure reaper reaps it. while (status.isPending()) { Clock::advance(Seconds(1)); Clock::settle(); } - Vinod Kone On Aug. 22, 2013, 7:37 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13747/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 7:37 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, > and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.cpp d53b8bb97da45834790cca6e04b70b969a8d3453 > src/tests/slave_recovery_tests.cpp 548e8c09875e4d911ac626b15a2556ff4fd8ff4b > > Diff: https://reviews.apache.org/r/13747/diff/ > > > Testing > ------- > > make check on Linux and OSX. > > > Thanks, > > Jiang Yan Xu > >
