----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13747/ -----------------------------------------------------------
(Updated Aug. 24, 2013, 5:41 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone. Changes ------- I needed the this patch to avoid this test being flaky... error occurred during test case TearDown(): https://github.com/xujyan/mesos/blob/699d708573737ea0225134bdcaf58f064eda3711/src/tests/mesos.cpp#L223 Looks like I cannot shut down the slave safely without first make sure the executor is terminated. Perhaps a problem with cgroups? ../../src/tests/mesos.cpp:223: Failure (cgroups::destroy(hierarchy, TEST_CGROUPS_ROOT)).failure(): Failed to kill tasks in nested cgroups: Collect failed: Failed to get tasks of cgroup: Failed to read cgroups control 'tasks': 'mesos_test/framework_201308240424-2081170186-43810-31294-0000_executor_623caa36-c7b4-4aaf-8b28-3e35083b2060_tag_23bbd0b5-fcfd-45dc-8fbc-e0c66b19733d' is not a valid cgroup [ FAILED ] SlaveRecoveryTest/1.MasterFailover, where TypeParam = mesos::internal::slave::CgroupsIsolator (3299 ms) Repository: mesos-git Description ------- See summary. Diffs (updated) ----- src/master/master.cpp 511332e9d53a224f7473eccaec64b94b4ce5a637 src/tests/slave_recovery_tests.cpp 548e8c09875e4d911ac626b15a2556ff4fd8ff4b Diff: https://reviews.apache.org/r/13747/diff/ Testing ------- make check on Linux and OSX. Thanks, Jiang Yan Xu
