----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13753/#review25448 -----------------------------------------------------------
nice test! src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13753/#comment49855> s/in/on/ src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13753/#comment49856> Is it guaranteed that the slaves offers won't be collapsed in one resourceOffers call? If yes, this needs a comment. src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13753/#comment49857> Instead of this, would it be cleaner to just start the 2nd slave after the first slave's offer is received by the framework? src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13753/#comment49858> pull this down to where the second slave is started. src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13753/#comment49859> These should be in a while loop for the command executor's reaper to reap it. - Vinod Kone On Aug. 22, 2013, 11:14 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13753/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 11:14 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod > Kone, and Jiang Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 548e8c0 > > Diff: https://reviews.apache.org/r/13753/diff/ > > > Testing > ------- > > make check > > Mac and Linux, repeat 100 times. > > > Thanks, > > Jie Yu > >
