> On Aug. 23, 2013, 4:22 p.m., Ian Downes wrote: > > src/tests/slave_recovery_tests.cpp, line 2039 > > <https://reviews.apache.org/r/13753/diff/1/?file=343980#file343980line2039> > > > > Would it be clearer to use ASSERT_LE so it reads the same as you'd > > write it? > > ASSERT_GE(offers1.get().size(), 0u); > > ASSERT_LE(offers1.get().size(), 2u);
In Google test the convention is that "actual" is first and "expected" is second in the argument list of EXPECT* and ASSERT*. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13753/#review25472 ----------------------------------------------------------- On Aug. 23, 2013, 9:18 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13753/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2013, 9:18 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod > Kone, and Jiang Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 548e8c0 > > Diff: https://reviews.apache.org/r/13753/diff/ > > > Testing > ------- > > make check > > Mac and Linux, repeat 100 times. > > > Thanks, > > Jie Yu > >
