----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13881/#review25661 -----------------------------------------------------------
Ship it! src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13881/#comment50157> I think you need to keep this and kill the above expectation at #1265. IIRC, driver.killTask() is what causes the offers to be fired? - Vinod Kone On Aug. 28, 2013, 5:37 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13881/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2013, 5:37 a.m.) > > > Review request for mesos, Ben Mahler, Chi Zhang, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Proper fix for the 400a88 commit to align with previous diff: > removes the double declaration (and the rest of that chunk) for KillTask > and fixes the GCExecutor test > > NOTE: tests are failing at ExamplesTest.PythonFramework but they also fail on > master at the previous commit. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 78f42ff > > Diff: https://reviews.apache.org/r/13881/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
