> On Aug. 28, 2013, 5:48 a.m., Vinod Kone wrote: > > src/tests/slave_recovery_tests.cpp, lines 1289-1293 > > <https://reviews.apache.org/r/13881/diff/1/?file=345487#file345487line1289> > > > > I think you need to keep this and kill the above expectation at #1265. > > IIRC, driver.killTask() is what causes the offers to be fired?
OK, I'd moved it to before the new slave was created but if it's triggered by killTask() then it can go in either place, if I understand correctly? If so, then yes, it's clearer to put it here. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13881/#review25661 ----------------------------------------------------------- On Aug. 28, 2013, 11:02 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13881/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2013, 11:02 p.m.) > > > Review request for mesos, Ben Mahler, Chi Zhang, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Proper fix for the 400a88 commit to align with previous diff: > removes the double declaration (and the rest of that chunk) for KillTask > and fixes the GCExecutor test > > NOTE: tests are failing at ExamplesTest.PythonFramework but they also fail on > master at the previous commit. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 78f42ff > > Diff: https://reviews.apache.org/r/13881/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
