----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13903/#review25808 -----------------------------------------------------------
src/linux/cgroups.hpp <https://reviews.apache.org/r/13903/#comment50340> I'll switch these to not be prefixed with set_ and use overloading instead to distinguish the reads vs writes. - Ben Mahler On Aug. 29, 2013, 9:03 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13903/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2013, 9:03 p.m.) > > > Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > I've adjusted the CgroupsIsolator code to use these new functions. > > Note that this always sets the soft_limit_in_bytes. This should have been > done in the first place, so let me know if you see a reason to conditionally > set the soft limit as before. > > > Diffs > ----- > > src/linux/cgroups.hpp 3989712b5b76bc960f03fdf020a4e5b735ba5d80 > src/linux/cgroups.cpp b97a89cafab12aa642645508ad465f714ee08f1b > src/slave/cgroups_isolator.cpp 676768e6b8bd13820467309814845257a9c47e02 > > Diff: https://reviews.apache.org/r/13903/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
