> On Aug. 31, 2013, 5:55 a.m., Vinod Kone wrote: > > src/slave/cgroups_isolator.cpp, line 1044 > > <https://reviews.apache.org/r/13903/diff/2/?file=347000#file347000line1044> > > > > Why not just do > > > > Bytes mem = Megabytes((uint64_t) resource.scalar().value()); ? > > Ben Mahler wrote: > This would lose accuracy! > > Take the example of mem == 0.5: > Megabytes((uint64_t) 0.5) == Megabytes(0)
good point! - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13903/#review25815 ----------------------------------------------------------- On Sept. 4, 2013, 2:43 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13903/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2013, 2:43 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > I've adjusted the CgroupsIsolator code to use these new functions. > > Note that this always sets the soft_limit_in_bytes. This should have been > done in the first place, so let me know if you see a reason to conditionally > set the soft limit as before. > > > Diffs > ----- > > src/linux/cgroups.hpp 3989712b5b76bc960f03fdf020a4e5b735ba5d80 > src/linux/cgroups.cpp b97a89cafab12aa642645508ad465f714ee08f1b > src/slave/cgroups_isolator.cpp 676768e6b8bd13820467309814845257a9c47e02 > > Diff: https://reviews.apache.org/r/13903/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
