----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14153/#review26279 -----------------------------------------------------------
How about doing the same thing glog does to handle this? They invoke the default signal handler after having processed the signal, grep for InvokeDefaultSignalHandler in the glog source. I suggest this mostly because I'm not sure if we can assume that the highest bit of the exit status signifies that we exited due to a signal (128 + signal). src/logging/logging.cpp <https://reviews.apache.org/r/14153/#comment51357> src/logging/logging.cpp <https://reviews.apache.org/r/14153/#comment51354> Ah, maybe this wasn't safe, see the reference to the C standard here about calling raise from within a handler: https://www.securecoding.cert.org/confluence/display/seccode/SIG33-C.+Do+not+recursively+invoke+the+raise()+function I should have just called abort here, but we should manually test that it behaves the same when when SIGPIPE is raised. - Ben Mahler On Sept. 16, 2013, 8:02 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14153/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2013, 8:02 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-694 > https://issues.apache.org/jira/browse/MESOS-694 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/logging/logging.cpp 0282b1f03e23f606d087d0d100999d413b066241 > > Diff: https://reviews.apache.org/r/14153/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
