----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14153/#review26387 -----------------------------------------------------------
Ship it! I don't see it in your testing comments but have you verified this still works as expected when manually sending kill signals to a running process? E.g. $ kill -s SIGTERM -> SIGTERM message, no stacktrace $ kill -s SIGPIPE -> SIGPIPE escalation message, stacktrace $ kill -s SIGFPE -> stacktrace - Ben Mahler On Sept. 24, 2013, 6:41 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14153/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2013, 6:41 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-694 > https://issues.apache.org/jira/browse/MESOS-694 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/logging/logging.cpp 0282b1f03e23f606d087d0d100999d413b066241 > > Diff: https://reviews.apache.org/r/14153/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
