-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14292/
-----------------------------------------------------------
(Updated Oct. 2, 2013, 10:43 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Joe Smith, Kevin
Sweeney, Tobias Weingartner, and Bill Farner.
Changes
-------
rebase. PTAL.
Bugs: MESOS-704
https://issues.apache.org/jira/browse/MESOS-704
Repository: mesos-git
Description
-------
Added authentication support for scheduler driver and master.
Diffs (updated)
-----
include/mesos/mesos.proto 957576bbc1c73513a9591194d017f76fe562a616
include/mesos/scheduler.hpp cf3ecdaaf40fd878a80fe0b6f7e61a0997329cbd
src/Makefile.am ee336130ad93d8b524c841f75be36f00d4a2b147
src/common/type_utils.hpp 674a8820c339c6446dfa7d444457477ab4512e79
src/examples/java/TestExceptionFramework.java
8ea55408686d898b52d3809afe216462127e64d1
src/examples/java/TestFramework.java 687ed0d012ccbb20ecb6830e9e86527273361298
src/examples/long_lived_framework.cpp
08ccc75df13467a1e823d35afe69cd0dc521fcf3
src/examples/no_executor_framework.cpp
3ffbbb7ad8df308ea2f55b6543fbaaf7ec7f212b
src/examples/python/test_framework.py
eb2012735a075233850788b7e9d138a78447bae6
src/examples/test_framework.cpp 0065de16c00a964959d1fceb824c436c20e992ee
src/java/jni/construct.cpp b01bd7ae2eda2dc5e0dcd68848c65bd9f9ea81f0
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp
6d2a03b6a88e71ac4e2e2d1ee8e15925e393ef3d
src/java/src/org/apache/mesos/MesosSchedulerDriver.java
7ef1fe7755286bf92b94d7ece4f72d54e5b57a84
src/master/flags.hpp d59e67d5b2799d6d7a37e9cfe7246ae7372091ac
src/master/master.hpp 0aeec7fc540d44c03c1171f31a7281a4b0055925
src/master/master.cpp ce8365f082a5f96ef64e33e526cb5047dff52127
src/python/native/mesos_scheduler_driver_impl.cpp
f25d41d38caf2701813dbec0d342a3b327e9dedf
src/sasl/authenticator.hpp 2f78cf0fdd97f0ddc3a6ebd162e6559497d708e4
src/sched/sched.cpp c399f2481259683a8e178abb3478307042292f23
src/tests/allocator_tests.cpp e5dc0d7d9d547046e2c410a860f312761c8af58b
src/tests/allocator_zookeeper_tests.cpp
6e3214c15c14dc8ba82082738c172c8833cd0887
src/tests/authentication_tests.cpp PRE-CREATION
src/tests/exception_tests.cpp 3fc1ac32d553644080a88f04f22077691ae1820b
src/tests/fault_tolerance_tests.cpp 10e52c401476eb8416361de49b8e4061bb7ac4f3
src/tests/gc_tests.cpp e404de3bfacfcac5515995f1b45c3d39181e138f
src/tests/isolator_tests.cpp cd3b3000060b379ef10e38a2a98a2eebe69d90fc
src/tests/master_detector_tests.cpp 2d140ba1a364a7af4d643951d6016ac17dd10526
src/tests/master_tests.cpp 52f09d4f1ddeabcc1a797a13fae9641b72425dd5
src/tests/mesos.hpp bc365fb17a25dbddaaffe0502c291f56a4b8f1a5
src/tests/mesos.cpp 776cb0f13d10b4ae437fe9a3c97dc8b3481290af
src/tests/resource_offers_tests.cpp 3888e461de5c8fa807cff2fd2bd7ca12c704823a
src/tests/script.cpp 847e6c571d632ed48214a0c0dfd870af75104c70
src/tests/slave_recovery_tests.cpp 097d43c1380274c8d2235d5c20f91c730f079355
src/tests/status_update_manager_tests.cpp
cf420e4764356402f05b27c3b8e8802c21a58f8e
Diff: https://reviews.apache.org/r/14292/diff/
Testing
-------
OSX:
make check
./bin/mesos-tests.sh --gtest_filter="*FaultTolerance*" --gtest_repeat=1000
--gtest_break_on_failure --gtest_shuffle
GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*Authentication*"
--gtest_repeat=1000 --gtest_break_on_failure
Linux:
make check GTEST_FILTER=''
Couldn't run tests on linux because the boxes I've access to do not support
SASL :/ It all compiles fwiw.
All our tests do auth now. yay!
ExamplesTest.JavaFramework is still flaky but I suspect it has nothing to do
with the current code because it is flaky even on "master" branch. Re-opened
https://issues.apache.org/jira/browse/MESOS-400 to track.
Thanks,
Vinod Kone
