----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14292/#review26846 -----------------------------------------------------------
Ship it! src/master/master.hpp <https://reviews.apache.org/r/14292/#comment52203> Owned? src/master/master.cpp <https://reviews.apache.org/r/14292/#comment52207> Can we update this comment to refer to exactly what will get called if we don't discard now but the discard occurs in the future in authenticationTimeout? src/master/master.cpp <https://reviews.apache.org/r/14292/#comment52208> ... is back in progress? I.e., we only queue it up once? Or maybe queue it back up? I'm okay with dropping it the second time let's just add some comments/log messages explaining as much. src/master/master.cpp <https://reviews.apache.org/r/14292/#comment52209> Ditto above. src/master/master.cpp <https://reviews.apache.org/r/14292/#comment52211> Owned? src/master/master.cpp <https://reviews.apache.org/r/14292/#comment52210> Owned? src/master/master.cpp <https://reviews.apache.org/r/14292/#comment52217> // Create a promise to capture the entire "authenticating" // procedure. We'll set this _after_ we finish _authenticate. Owned<Promise<Nothing>> promise = new Promise<Nothing>(); // Create the authenticator. Owned<sasl::Authenticator> authenticator = new sasl::Authenticator(from)); // Start authentication. authenticator->authenticate() .onAny(defer(self(), &Self::_authenticate, pid, promise, lambda::_1)); // Don't wait for authentication to happen for ever. delay(Seconds(5), self(), &Self::authenticationTimeout, promise->future()); // Save our state. authenticating[pid] = promise->future(); authenticators[pid] = authenticator; src/sched/sched.cpp <https://reviews.apache.org/r/14292/#comment52218> Owned? src/sched/sched.cpp <https://reviews.apache.org/r/14292/#comment52219> No need with an Owned. - Benjamin Hindman On Oct. 9, 2013, 5:46 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14292/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2013, 5:46 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Joe Smith, Kevin > Sweeney, Tobias Weingartner, and Bill Farner. > > > Bugs: MESOS-704 > https://issues.apache.org/jira/browse/MESOS-704 > > > Repository: mesos-git > > > Description > ------- > > Added authentication support for scheduler driver and master. > > > Diffs > ----- > > include/mesos/mesos.proto 957576bbc1c73513a9591194d017f76fe562a616 > include/mesos/scheduler.hpp cf3ecdaaf40fd878a80fe0b6f7e61a0997329cbd > src/common/type_utils.hpp 674a8820c339c6446dfa7d444457477ab4512e79 > src/java/jni/construct.cpp b01bd7ae2eda2dc5e0dcd68848c65bd9f9ea81f0 > src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp > 6d2a03b6a88e71ac4e2e2d1ee8e15925e393ef3d > src/java/src/org/apache/mesos/MesosSchedulerDriver.java > 7ef1fe7755286bf92b94d7ece4f72d54e5b57a84 > src/master/flags.hpp d59e67d5b2799d6d7a37e9cfe7246ae7372091ac > src/master/master.hpp bed051c6f82e07777a087b3632c8644f8e59f88a > src/master/master.cpp cdfae1d46831c2de1fb535f60b38029fc1a0b9bb > src/python/native/mesos_scheduler_driver_impl.cpp > f25d41d38caf2701813dbec0d342a3b327e9dedf > src/sasl/authenticator.hpp 2f78cf0fdd97f0ddc3a6ebd162e6559497d708e4 > src/sched/sched.cpp c399f2481259683a8e178abb3478307042292f23 > > Diff: https://reviews.apache.org/r/14292/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
