> On Oct. 10, 2013, 11:47 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 764-765 > > <https://reviews.apache.org/r/14292/diff/16/?file=363499#file363499line764> > > > > framework id might be useful in all of these log messages
we don't have framework id yet when a framework is registering. > On Oct. 10, 2013, 11:47 p.m., Ben Mahler wrote: > > src/master/master.cpp, line 765 > > <https://reviews.apache.org/r/14292/diff/16/?file=363499#file363499line765> > > > > align the << done > On Oct. 10, 2013, 11:47 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 247-248 > > <https://reviews.apache.org/r/14292/diff/16/?file=363499#file363499line247> > > > > You could mention that this is because delay uses the pid() and if the > > master is stopped / started the pid remains the same, hence the dispatch on > > the new master. done. > On Oct. 10, 2013, 11:47 p.m., Ben Mahler wrote: > > src/master/master.cpp, line 1676 > > <https://reviews.apache.org/r/14292/diff/16/?file=363499#file363499line1676> > > > > in-progress (since this is a compound adjective) :) http://idioms.thefreedictionary.com/in+progress :) - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14292/#review26909 ----------------------------------------------------------- On Oct. 10, 2013, 10:26 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14292/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2013, 10:26 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Joe Smith, Kevin > Sweeney, Tobias Weingartner, and Bill Farner. > > > Bugs: MESOS-704 > https://issues.apache.org/jira/browse/MESOS-704 > > > Repository: mesos-git > > > Description > ------- > > Added authentication support for scheduler driver and master. > > > Diffs > ----- > > include/mesos/mesos.proto 957576bbc1c73513a9591194d017f76fe562a616 > include/mesos/scheduler.hpp cf3ecdaaf40fd878a80fe0b6f7e61a0997329cbd > src/common/type_utils.hpp 674a8820c339c6446dfa7d444457477ab4512e79 > src/java/jni/construct.cpp b01bd7ae2eda2dc5e0dcd68848c65bd9f9ea81f0 > src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp > 6d2a03b6a88e71ac4e2e2d1ee8e15925e393ef3d > src/java/src/org/apache/mesos/MesosSchedulerDriver.java > 7ef1fe7755286bf92b94d7ece4f72d54e5b57a84 > src/master/flags.hpp d59e67d5b2799d6d7a37e9cfe7246ae7372091ac > src/master/master.hpp bed051c6f82e07777a087b3632c8644f8e59f88a > src/master/master.cpp 2fd48a6a3320ad8d3063bf3a31eda4e5f89bee35 > src/python/native/mesos_scheduler_driver_impl.cpp > f25d41d38caf2701813dbec0d342a3b327e9dedf > src/sasl/authenticator.hpp 2f78cf0fdd97f0ddc3a6ebd162e6559497d708e4 > src/sched/sched.cpp c399f2481259683a8e178abb3478307042292f23 > > Diff: https://reviews.apache.org/r/14292/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
