----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14635/#review27035 -----------------------------------------------------------
Ship it! src/webui/master/static/js/app.js <https://reviews.apache.org/r/14635/#comment52639> Should this be: truncatedIdParts.splice(3, Number.MAX_VALUE)? - Ben Mahler On Oct. 14, 2013, 10:38 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14635/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2013, 10:38 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Truncated only Mesos IDs that look like UUIDs. > > Framework IDs are truncated regardless of their format right now, but > frameworks assign their own IDs without any restrictions. For frameworks > that use IDs that don't look like UUIDs, they end up with just empty > strings as their truncated IDs. > > > Diffs > ----- > > src/webui/master/static/js/app.js 92e8e2dd36091f109be3cf3ce26fd23f558e6890 > > Diff: https://reviews.apache.org/r/14635/diff/ > > > Testing > ------- > > > Thanks, > > Ross Allen > >
