> On Oct. 15, 2013, 6:05 p.m., Ben Mahler wrote:
> > src/webui/master/static/js/app.js, line 51
> > <https://reviews.apache.org/r/14635/diff/1/?file=364617#file364617line51>
> >
> > Should this be:
> >
> > truncatedIdParts.splice(3, Number.MAX_VALUE)?
> >
> >
Actually, if this is meant to select everything beyond the 3rd index, `slice`
is the more appropriate call.
truncatedIdParts.slice(3).join('-')
I didn't see your comment until after I pushed to master, so I'll send another
request to change it.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14635/#review27035
-----------------------------------------------------------
On Oct. 14, 2013, 10:38 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14635/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2013, 10:38 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Truncated only Mesos IDs that look like UUIDs.
>
> Framework IDs are truncated regardless of their format right now, but
> frameworks assign their own IDs without any restrictions. For frameworks
> that use IDs that don't look like UUIDs, they end up with just empty
> strings as their truncated IDs.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js 92e8e2dd36091f109be3cf3ce26fd23f558e6890
>
> Diff: https://reviews.apache.org/r/14635/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>
